Filter release candidates out of update checker #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I personally think it's good that we present release candidates to our users through the update checker. I do however also think that before doing that we might need provide the user with the choice between a stable release and a release candidate with accompanying release notes. For now this quick fix is fine with me. |
chchwy
approved these changes
Sep 20, 2025
Member
|
Thanks for the fix. Please change the merge target to |
8cc6dac to
3d161ec
Compare
chchwy
approved these changes
Sep 22, 2025
Member
|
Alright I am going to merge it and cherry-pick it to the 0.7.1 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really minimal solution to avoid release candidates from being presented as a new release when users check for updates. The releases.atom does not provide the information necessary to distinguish prereleases from full releases. The nightly build link was wrong so I updated that at the same time.
I would like to eventually use the GitHub API instead, which does provide prerelease information, and fall back to the atom, or perhaps even other sources in case GitHub is down or blocked. However I'm going to leave that as a future improvement as I want to get this fix into v0.7.1. Given how close v0.7.1 is to release, I think this small hack is the best short-term solution.