这是indexloc提供的服务，不要输入任何密码
Skip to content

Filter release candidates out of update checker #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Filter release candidates out of update checker #1930

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b401ba
Filter RCs out of update checker
scribblemaniac Sep 13, 2025
3d161ec
Fix nightly build download link
scribblemaniac Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/checkupdatesdialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ void CheckUpdatesDialog::nightlyBuildCheck()
{
mTitleLabel->setText(tr("<b>You are using a Pencil2D nightly build</b>"));
mDetailLabel->setText(tr("Please go %1 here %2 to check new nightly builds.")
.arg("<a href=\"https://www.pencil2d.org/download/#nightlybuild\">", "</a>"));
.arg("<a href=\"https://www.pencil2d.org/download/nightly/\">", "</a>"));
mDetailLabel->setOpenExternalLinks(true);
mProgressBar->setRange(0, 1);
mProgressBar->setValue(1);
Expand Down Expand Up @@ -212,8 +212,12 @@ QString CheckUpdatesDialog::getVersionNumberFromXml(QString xml)
xmlReader.readNext();
if (xmlReader.name() == QLatin1String("title"))
{
QString titleTag = xmlReader.readElementText();
return titleTag.remove(QRegularExpression("^v")); // remove the leading 'v'
QString title = xmlReader.readElementText();
title = title.remove(QRegularExpression("^v")); // remove the leading 'v'
// Ignore release candidate versions
if (!title.contains("Release Candidate")) {
return title;
}
}
}
}
Expand Down
Loading