-
Notifications
You must be signed in to change notification settings - Fork 293
Painting blitting improvements v2 camera #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
J5lx
merged 61 commits into
pencil2d:master
from
MrStevns:painting-blitting-improvements-v2-camera
Oct 1, 2023
Merged
Painting blitting improvements v2 camera #1789
J5lx
merged 61 commits into
pencil2d:master
from
MrStevns:painting-blitting-improvements-v2-camera
Oct 1, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split painting for current frame and onion skinning - Introduce blitRect for updating only the dirty portion of the frame - Optimization: Only do an expensive fill when the size changes, otherwise rely on the blitRect to clear the dirty portion.
Aside from cleaning up various extra update methods that are no longer necessary, I've made a minor change in vectorImage, in order to get it's correct dirty region.
This was a necessary change in order to calculate the correct bounds that wouldn't draw artifacts.
This also fixes some inconsistency in the CanvasPainter that I couldn't make sense of..
Although i don't like that this exists in our painter, I believe we added it because for some reason the image hasn't been loaded yet, so let's leave it for now... ideally though i've really like to get rid of such weird mutable things that has little to do with painting.
Additionally this will fix some artifacts when smudging
- Note that VectorImage hasn't been implemented yet.
This was causing the gaps to be drawn between the tiled buffer tiles in some cases... particularly when erasing and you had zoomed in or out.
…nts-v2 Fix ScribbleArea repaint when tiled buffer does not cover update rect
…ng-improvements-v2-camera
…ng-improvements-v2-camera
…ng-improvements-v2-camera
…ng-improvements-v2-camera
in order to support HDPI properly
J5lx
approved these changes
Oct 1, 2023
Member
J5lx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another performance improvement PR, pretty much the same changes I applied to the CanvasPainter