这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@MrStevns
Copy link
Member

@MrStevns MrStevns commented Oct 1, 2023

Another performance improvement PR, pretty much the same changes I applied to the CanvasPainter

MrStevns and others added 30 commits April 22, 2023 12:00
- Split painting for current frame and onion skinning
- Introduce blitRect for updating only the dirty portion of the frame
- Optimization: Only do an expensive fill when the size changes, otherwise rely on the blitRect to clear the dirty portion.
Aside from cleaning up various extra update methods that are no longer necessary, I've made a minor change in vectorImage, in order to get it's correct dirty region.
This was a necessary change in order to calculate the correct bounds that wouldn't draw artifacts.
This also fixes some inconsistency in the CanvasPainter that I couldn't make sense of..
Although i don't like that this exists in our painter, I believe we added it because for some reason the image hasn't been loaded yet, so let's leave it for now... ideally though i've really like to get rid of such weird mutable things that has little to do with painting.
Additionally this will fix some artifacts when smudging
- Note that VectorImage hasn't been implemented yet.
This was causing the gaps to be drawn between the tiled buffer tiles in some cases... particularly when erasing and you had zoomed in or out.
MrStevns and others added 23 commits August 13, 2023 11:11
…nts-v2

Fix ScribbleArea repaint when tiled buffer does not cover update rect
in order to support HDPI properly
@MrStevns MrStevns mentioned this pull request Oct 1, 2023
6 tasks
@J5lx J5lx added this to the v0.6.7 milestone Oct 1, 2023
@J5lx J5lx self-assigned this Oct 1, 2023
Copy link
Member

@J5lx J5lx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@J5lx J5lx merged commit d3be339 into pencil2d:master Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants