Bugfixes 2 #1213
Merged
Bugfixes 2 #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bucket tool rounded the point selected, which meant that sometimes it would fill the adjacent pixel rather than the selected pixel.
If, in the middle of drawing a stroke, you click the right mouse button, the resulting stroke will stay on the screen because the second pointerReleaseEvent never got called. This should be fixed now
Now it produces a warning when you try to zoom/pan on a hidden camera layer and does not produce a warning when panning with the middle mouse button on a non-camera layer.
This prevents confusion or bugs over what is being changed when no element is initially selected
I'M A' FIRIN' MAH ERASOR!
MrStevns
approved these changes
Apr 20, 2019
Member
MrStevns
left a comment
There was a problem hiding this comment.
Aside from a suggestion, I don't see anything wrong here.
Closed
Member
Author
|
I am merging this now with only one reviewer due to our current limited resources and imminent v0.6.4 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my second set of bugfixes for v0.6.4, same deal as last time. c0af82a was the last big issue I wanted to fix. Lots of issues remain, mostly vector or selection tool related, but they can wait.
e1db3a7 will probably be partially undone by #1211 and will require some extra attention after merging both of these PRs.Edit: #1211 No longer conflicts with my changes here.