#950 - always make sure there's a keyframe when drawing #1211
Conversation
- updated isKeyframeSane with check to verify draw_on_empty_frame_action
scribblemaniac
left a comment
There was a problem hiding this comment.
This PR currently introduces a bug with the automatic create new keyframe behavior that needs to be addressed before merging. There may need to be further discussion about how the automatic duplicate frame option should behave when there is no explicit previous keyframe.
- This reworks the whole handleDrawingOnEmptyFrame by always making sure there's a frame to paint on. No matter which frame frame is selected, the user can always expect to draw on the canvas. If the first frame is empty and the action is "draw on previous keyframe" then a keyframe will be created. The same will happen for "duplicate previous keyframe" in case there's none. This should also eliminate other checks that requires there to be a keyframe because there will always be one now.
|
I've reworked the PR... basically based on what you said @scribblemaniac , I agree that it's better if we always allow the user to draw on the canvas instead of ignoring their input. The new logic makes sure that if you draw on the canvas while there is no previous keyframe, then one will be created for you. This is true for both "drawing on previous keyframe" and "duplicate previous keyframe" |
scribblemaniac
left a comment
There was a problem hiding this comment.
I made a small suggestion, but overall this is good now. I like the new solution, it simplifies many things!
|
I am merging this now with only one reviewer due to our current limited resources and imminent v0.6.4 release. |
Fixes #950