-
Notifications
You must be signed in to change notification settings - Fork 194
LUI-200: Added support for Bamboo Specs. #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is this ready for review? |
|
Yes @dkayiwa. |
| final: false | ||
| jobs: | ||
| - Build and Test JDK 17 | ||
| - Build and Test JDK 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intentionally leave out Java 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, since that's already being handled by the 1.x branch — which I assume is the main reason that branch is being maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the original plan. But after some discussions on the previous platform calls, it was agreed that unless there is a really increased complexity to do so, we should try our best to still support Java 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, alright. Sorry I guess I missed that. Let me quickly update this PR.
|
Is this the corresponding plan? https://ci.openmrs.org/browse/LU-LUL |
|
Yes, that’s the correct plan. Now that this is merged, I’ll proceed to let Bamboo know of this and make sure it’s no longer editable from the Bamboo UI. |
|
Can you ping me as soon as you have done that? |
|
Yes, accomplished @dkayiwa. |
|
So how do i see which builds failed and which one passed like we see with github actions? |
|
Since there's no triggering commit after the specs have been merged and configured, you could fire-up a manual run of the plan on Bamboo to see some build results. |
Ticket: https://openmrs.atlassian.net/browse/LUI-200