这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Ruhanga
Copy link
Member

@Ruhanga Ruhanga commented Jun 5, 2025

@dkayiwa
Copy link
Member

dkayiwa commented Jun 5, 2025

Is this ready for review?

@Ruhanga
Copy link
Member Author

Ruhanga commented Jun 6, 2025

Yes @dkayiwa.

final: false
jobs:
- Build and Test JDK 17
- Build and Test JDK 24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally leave out Java 8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since that's already being handled by the 1.x branch — which I assume is the main reason that branch is being maintained.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the original plan. But after some discussions on the previous platform calls, it was agreed that unless there is a really increased complexity to do so, we should try our best to still support Java 8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, alright. Sorry I guess I missed that. Let me quickly update this PR.

@Ruhanga Ruhanga requested a review from dkayiwa June 6, 2025 12:15
@dkayiwa dkayiwa merged commit 666651f into openmrs:master Jun 6, 2025
5 checks passed
@dkayiwa
Copy link
Member

dkayiwa commented Jun 6, 2025

Is this the corresponding plan? https://ci.openmrs.org/browse/LU-LUL
I just want to confirm that i should not be able to edit from the Bamboo UI.

@Ruhanga
Copy link
Member Author

Ruhanga commented Jun 6, 2025

Yes, that’s the correct plan. Now that this is merged, I’ll proceed to let Bamboo know of this and make sure it’s no longer editable from the Bamboo UI.

@dkayiwa
Copy link
Member

dkayiwa commented Jun 6, 2025

Can you ping me as soon as you have done that?

@Ruhanga
Copy link
Member Author

Ruhanga commented Jun 6, 2025

Yes, accomplished @dkayiwa.

@dkayiwa
Copy link
Member

dkayiwa commented Jun 7, 2025

So how do i see which builds failed and which one passed like we see with github actions?

@Ruhanga
Copy link
Member Author

Ruhanga commented Jun 8, 2025

Since there's no triggering commit after the specs have been merged and configured, you could fire-up a manual run of the plan on Bamboo to see some build results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants