[modbus] Connection timeout parameter for TCP slaves. #4627
Conversation
|
@botura please test the version linked here, and share your experiences. The default timeout is OS default ("infinite"). The configuration was documented in the issue. |
|
@ssalonen, it worked as expected. I´ll make new tests during the weekend, but I believe everything is ok! |
| return m_ConnectTimeoutMillis; | ||
| } | ||
|
|
||
| public void setConnectTimeoutMillis(int m_ConnectTimeoutMillis) { |
There was a problem hiding this comment.
Is the m_ prefix for the method parameter make sense? (obv. very minor point)
There was a problem hiding this comment.
I agree that it does not really make sense but I'm keeping the "jamod" (net.wimpi.modbus) code base consistent.
For whatever reason they (=original authors of jamod) are prefixing the private variables with m_.
Perhaps at some point we should consider formatting the whole net.wimpi.modbus code to comform to modern java style guide.
|
I'm good with the merge if @botura is happy. |
|
Pretty happy @ssalonen. With this enhancement I can definitely use OH in my system. |
|
Wiki updated. |
* master: (30 commits) [satel] Fixed refresh after control command (openhab#4674) [IPX800] Add binding to OH2 distro (openhab#4684) Database update (openhab#4692) ZWave database update (openhab#4679) [xbmc] Minor formatting (openhab#4683) some changes to XBMC binding (openhab#4622) [telegram] sendTelegramPhoto caption should be UTF-8 (openhab#4650) New api url for forecastio provider (openhab#4677) Review 1: Patch for: Error on startup with SQLite openhab#4652 (openhab#4670) [Plugwise] Fix Circles not always calibrated (openhab#4669) Database update (openhab#4664) [garadget] Remove misleading text on exception logs (openhab#4663) Fixes openhab#4635 (openhab#4649) [Plugwise] NullPointerException may occur when concurrent threads get PlugwiseDevice from Stick (openhab#4648) insteonplm binding: added mini remote 2342-222 (openhab#4641) [modbus] Connection timeout parameter for TCP slaves. (openhab#4627) [Plugwise] Add openHAB 2 feature addon (openhab#4644) fixes build problems [Plugwise] Add support for Scan, Sense, Stealth and Switch openhab#4565 (openhab#4586) [satel] Added rule action to set user code (openhab#4634) ...
Resolves #4595
The default connection timeout is zero which is basically matches the previous behavior (OS default or infinite).
Pre-compiled JAR available at https://github.com/ssalonen/openhab/releases/tag/modbus-timeout-pr-2016-09-07
TODO (once merged): wiki page update