This repository was archived by the owner on May 17, 2021. It is now read-only.
[Plugwise] Fix Circles not always calibrated #4669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wouter Born <github@maindrain.net> (github: wborn)
cdjackson
added a commit
to cdjackson/openhab1-addons
that referenced
this pull request
Oct 9, 2016
* master: (30 commits) [satel] Fixed refresh after control command (openhab#4674) [IPX800] Add binding to OH2 distro (openhab#4684) Database update (openhab#4692) ZWave database update (openhab#4679) [xbmc] Minor formatting (openhab#4683) some changes to XBMC binding (openhab#4622) [telegram] sendTelegramPhoto caption should be UTF-8 (openhab#4650) New api url for forecastio provider (openhab#4677) Review 1: Patch for: Error on startup with SQLite openhab#4652 (openhab#4670) [Plugwise] Fix Circles not always calibrated (openhab#4669) Database update (openhab#4664) [garadget] Remove misleading text on exception logs (openhab#4663) Fixes openhab#4635 (openhab#4649) [Plugwise] NullPointerException may occur when concurrent threads get PlugwiseDevice from Stick (openhab#4648) insteonplm binding: added mini remote 2342-222 (openhab#4641) [modbus] Connection timeout parameter for TCP slaves. (openhab#4627) [Plugwise] Add openHAB 2 feature addon (openhab#4644) fixes build problems [Plugwise] Add support for Scan, Sense, Stealth and Switch openhab#4565 (openhab#4586) [satel] Added rule action to set user code (openhab#4634) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a lot of Circles they may not all get calibrated at startup. Either the
CalibrationRequestMessagemay never be received by a Circle, or theCalibrationResponseMessagemay get lost. Also Circles may be offline during startup. As a result the 'current power' of an uncalibrated Circle will always remain 0 W.This PR fixes it by resending a
CalibrationRequestMessagewhenever aPowerInformationResponseMessageis received for an uncalibrated Circle.Signed-off-by: Wouter Born github@maindrain.net (github: wborn)