This repository was archived by the owner on May 17, 2021. It is now read-only.
fix for #1403 - makes Actions visible in Designer #2967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e2f826e to
87a904d
Compare
Member
Author
|
unfortunately my.openHAB Action is still not working properly |
Member
There was a problem hiding this comment.
A bundle must not import internal packages from other bundles.
Member
Author
There was a problem hiding this comment.
Absolutely right and we should change this (out of the scope of this Bugfix). What i changed was simply removing the require-bundle deep and add the import-package instead. @gerrieg could you please take care of this and create another PR moving the externally required classes in the appropriate package?
This was referenced Jul 27, 2015
Contributor
|
The homematic action requires a correctly configured homematic binding (no item). If a action should not reference a binding, what's the correct way to implement this? |
87a904d to
f5d0411
Compare
…pendencies in order to activate them as soon as classes are needed Signed-off-by: Thomas Eichstädt-Engelen <thomas@openhab.org>
f5d0411 to
9cb021a
Compare
teichsta
added a commit
that referenced
this pull request
Jul 31, 2015
fix for #1403 - make Actions visible in Designer
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 1, 2015
…Designer; moved messages package out of internal; made ecobeeSetHold temp parameters truly optional.
Contributor
|
I can confirm MiOS action is now visible in Designer 1.7.1. |
Contributor
|
I can confirm Squeezebox action is now visible in Designer 1.7.1 |
Merged
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 23, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional.
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 26, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
paolodenti
pushed a commit
to paolodenti/openhab
that referenced
this pull request
Sep 28, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
paolodenti
pushed a commit
to paolodenti/openhab
that referenced
this pull request
Oct 1, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
especially added bundle activationpolicy to dependencies in order to activate them as soon as classes are needed
Signed-off-by: Thomas Eichstädt-Engelen thomas@openhab.org