This repository was archived by the owner on May 17, 2021. It is now read-only.
Ecobee bug: Only update item if we know we retrieved the thermostat it refers to. #2765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teichsta
added a commit
that referenced
this pull request
Jun 20, 2015
Ecobee bug: Only update item if we know we retrieved the thermostat it refers to.
Member
|
Thanks @watou! |
|
openHAB » openhab #3205 FAILURE |
watou
added a commit
to watou/openhab
that referenced
this pull request
Jul 22, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942)
watou
added a commit
to watou/openhab
that referenced
this pull request
Jul 28, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942)
watou
added a commit
to watou/openhab
that referenced
this pull request
Jul 31, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942)
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 23, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional.
watou
added a commit
to watou/openhab
that referenced
this pull request
Aug 26, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
paolodenti
pushed a commit
to paolodenti/openhab
that referenced
this pull request
Sep 28, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
paolodenti
pushed a commit
to paolodenti/openhab
that referenced
this pull request
Oct 1, 2015
* mult-ecobees-1-acct-bug (PR openhab#2765) * ecobee-celsius-arithmetic-exception (openhab#2793) * ecobee-discard-tokens (PR openhab#2849) * ecobee-echo-cancellation (PR openhab#2942) * changes similar to @teichsta's PR openhab#2967 so actions now appear in Designer; moved messages package out of internal; made ecobeeSetHold temp paramter truly optional. * Quiesce logging when network failure keeps a poll from completing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users of the Ecobee binding who have more than one thermostat that are managed under the same account at ecobee.com, this is an important bugfix that ought to be in 1.7.1. The
readEcobeemethod was iterating through all in-bound items from that account and setting their states, even if the thermostat that that item refers to had not changed and was therefore not in the payload returned from ecobee, resulting in sometimes Uninitialized items.