[dscalarm] Fix update of channel zone_bypass_mode
#18056
Merged
+296
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51c105e to
85b1735
Compare
Signed-off-by: Vasilis Pantelis <pantelva.me@gmail.com>
85b1735 to
288d64b
Compare
zone_bypass_mode
lsiepel
approved these changes
Feb 19, 2025
Contributor
There was a problem hiding this comment.
Thanks for fixing this. I would say this should also be backported. wdyt?
Would also be nice if @RSStephens can comment on this PR.
LGTM
Member
|
Hello @vpant, Good job in implementing this into the DSCAlarm binding; it is well over due. Here is a discussion on it in the forum. Although, I'm not sure this is a bug fix. I would consider it more of a feature enhancement , as this Envisalink TPI command (616) was added in a later version of the software. The binding was originally developed on an earlier version (1.04) of the Envisalink TPI, and has never been upgraded to include this feature. So, thank you for working on this. LGTM |
RSStephens
approved these changes
Feb 20, 2025
matgroe
pushed a commit
to matgroe/openhab-addons
that referenced
this pull request
Feb 24, 2025
…b#18056) Signed-off-by: Vasilis Pantelis <pantelva.me@gmail.com>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
…b#18056) Signed-off-by: Vasilis Pantelis <pantelva.me@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bypassing a zone from the keypad did not reflect the change in openhab, although envisalink board issues a Process Bypassed Zones Bitfield Dump (616) command that can be used to update the appropriate channels.
This change will start processing Bypassed Zones Bitfield Dump (616) command and update every zone's
zone_bypass_modechannel and it is documented here