Replace pylint, pydocstyle with ruff check #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f98965 to
a6b7f01
Compare
Replaces pylint and pydocstyle linters with `ruff check`, and configures Ruff's lint rules. All lints that are not able to be auto-fixed or trivially fixable by hand are temporarily disabled to keep the diff smaller.
a30e54f to
a2e01ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches out pylint and pydocstyle for
ruff check, fixing any lints that areautomatically fixable, temporarily disabling all others, and removing all
existing lint control comments from those two linters. In the interest of
keeping the diff here even slightly manageable, I'm going to go through the
disabled lints one-by-one in separate MRs and either fix/re-enable them or leave
a note about why they're being left permanently disabled.
I've enabled some lint rulesets that don't correspond to the linters we were
using previously, as Ruff doesn't have duplicate codes for rules that were
applied by multiple linters, and as a result some rules that we relied on Pylint
for are categorized elsewhere (mainly pyflakes).
#109