Replace pylint, pydocstyle with ruff check #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lints cover some of what pylint previously did for us -- ruff doesn't include them in both rulesets because they are redundant.
2783c14 to
0a54bc4
Compare
4d0deb7 to
e62e576
Compare
Maegereg
approved these changes
Nov 10, 2025
d1cfa0e to
ea0bb60
Compare
Replaces links to projects.iq.harvard.edu with Wayback Machine links, as that site has shut down. Also updates intersphinx to point to a (hopefully more stable) location for the Spark docs, and fixes a missing import in some doctests.
5f199bd to
42e41b4
Compare
Contributor
|
Looks like the apache hive wiki is moving - I don't know if that's what's causing the latest round of errors, but maybe worth trying updating the links to the new location? I can't suggest them since you haven't edited the spark topic guide, but the new links are https://hive.apache.org/docs/latest/admin/adminmanual-metastore-3-0-administration/ and https://hive.apache.org/docs/latest/user/hiveserver2-clients/#beeline-hive-commands |
tmager
added a commit
to opendp/tumult-analytics
that referenced
this pull request
Nov 14, 2025
github-merge-queue bot
pushed a commit
to opendp/tumult-analytics
that referenced
this pull request
Nov 15, 2025
* Replace pylint, pydocstyle with ruff check Replaces pylint and pydocstyle linters with `ruff check`, and configures Ruff's lint rules. All lints that are not able to be auto-fixed or trivially fixable by hand are temporarily disabled to keep the diff smaller. * Disable RUF010 and revert changes it introduced * Remove unneeded whitespace where pylint control comments were removed * Update pyspark intersphinx location to match Core * Fix doctests, pull in changes from opendp/tumult-core#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches out pylint and pydocstyle for
ruff check, fixing any lints that are automatically fixable, temporarily disabling all others, and removing all existing lint control comments from those two linters.In the interest of keeping the diff here even slightly manageable, I'm going to go through the disabled lints one-by-one in separate MRs and either fix/re-enable them or leave a note about why they're being left permanently disabled.
I've enabled some additional lint rule sets that don't correspond to the linters we were using previously, as Ruff doesn't have duplicate codes for rules that were applied by multiple linters, and as a result some rules that we relied on Pylint for are categorized elsewhere (mainly pyflakes). The set of enabled rules will continue to evolve over time as we notice things that should be getting caught but aren't.
opendp/tumult-analytics#109