Alternate overflow options #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
This was referenced Apr 14, 2025
jamesnw
commented
Apr 16, 2025
| strategy: 'absolute', | ||
| } as unknown as MiddlewareState, | ||
| { | ||
| boundary: offsetParent, | ||
| rootBoundary: 'document', |
There was a problem hiding this comment.
As context, if I recall correctly, I was being overly explicit in this call, but it turns out these options are not always correct, and the defaults are actually what we want.
jgerigmeyer
approved these changes
Apr 21, 2025
I've noticed this as well. I opened #325 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overflow checking was not working as expected for
position-try-fallbackswith the viewport as the containing block.Related Issue(s)
#317
Steps to test/reproduce