-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add built polyfill to Netlify build #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to CONTRIBUTING.md, since this is for contributors, not for users. |
I don't see any potential trouble either. My only worry is: if someone uses the script from our Netlify site in a high traffic project, are we going to pay for bandwidth? |
Potentially. It looks like we have bandwidth for roughly 6 million requests per month, so it's theoretically not impossible. It's $55 per 100GB over. It would be easy to turn off if it seems like an issue. |
Description
Build polyfill on Netlify, allow for serving from there
Related Issue(s)
#299
Steps to test/reproduce
Load https://codepen.io/jamessw/pen/NPWydvW/353a442db275b4cd1e27d8d6a7253eb0 in non-Chromium. Check that the polyfill works, and is loaded from the preview.
This currently would allow the same on the production environments. How big of an issue is that? It looks like a bigger tooling lift to change headers per branch.