这是indexloc提供的服务,不要输入任何密码
Skip to content

Add built polyfill to Netlify build #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 17, 2025
Merged

Add built polyfill to Netlify build #300

merged 5 commits into from
Mar 17, 2025

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Mar 17, 2025

Description

Build polyfill on Netlify, allow for serving from there

Related Issue(s)

#299

Steps to test/reproduce

Load https://codepen.io/jamessw/pen/NPWydvW/353a442db275b4cd1e27d8d6a7253eb0 in non-Chromium. Check that the polyfill works, and is loaded from the preview.

This currently would allow the same on the production environments. How big of an issue is that? It looks like a bigger tooling lift to change headers per branch.

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for anchor-polyfill ready!

Name Link
🔨 Latest commit d78d723
🔍 Latest deploy log https://app.netlify.com/sites/anchor-polyfill/deploys/67d85578c5aa2e000878bf05
😎 Deploy Preview https://deploy-preview-300--anchor-polyfill.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 17, 2025

Deploy Preview for anchor-position-wpt canceled.

Name Link
🔨 Latest commit d78d723
🔍 Latest deploy log https://app.netlify.com/sites/anchor-position-wpt/deploys/67d85578178af300086c96c9

@jamesnw jamesnw requested review from jgerigmeyer and jerivas and removed request for jgerigmeyer March 17, 2025 14:57
@jgerigmeyer jgerigmeyer linked an issue Mar 17, 2025 that may be closed by this pull request
Copy link
Member

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I'll let @jerivas speak to any concerns about allowing this in prod -- I can't think of any issues?

@jamesnw Do we want to add some documentation along with this?

@jamesnw
Copy link
Contributor Author

jamesnw commented Mar 17, 2025

@jamesnw Do we want to add some documentation along with this?

Added to CONTRIBUTING.md, since this is for contributors, not for users.

@jerivas
Copy link
Member

jerivas commented Mar 17, 2025

I don't see any potential trouble either. My only worry is: if someone uses the script from our Netlify site in a high traffic project, are we going to pay for bandwidth?

@jamesnw
Copy link
Contributor Author

jamesnw commented Mar 17, 2025

I don't see any potential trouble either. My only worry is: if someone uses the script from our Netlify site in a high traffic project, are we going to pay for bandwidth?

Potentially. It looks like we have bandwidth for roughly 6 million requests per month, so it's theoretically not impossible. It's $55 per 100GB over. It would be easy to turn off if it seems like an issue.

@jgerigmeyer jgerigmeyer merged commit 1e32d46 into main Mar 17, 2025
14 checks passed
@jgerigmeyer jgerigmeyer deleted the polyfill-preview branch March 17, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable testing of PR versions of Polyfill
3 participants