这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@simonseyock
Copy link
Collaborator

@simonseyock simonseyock commented Nov 15, 2024

The remove_timestamp and before_timestamp could have 3 different kinds of values with different meanings. That made the code difficult to read and led to some errors. The possibilities were:

  • {number} - an actual timestamp the tiles would be compared to
  • None - means that the tile should not be considered stale at any time
  • 0 - means that the tile should be deleted/refreshed no matter what

I removed the 0 meaning and added remove_all and refresh_all parameters that gets passed into every function where this check is performed. In my opinion that makes the code more understandable.

It also adds a handle_all option to the TileWalker which is used for more complex seeding and cleanup tasks. This option means that all existing tiles will be handled.

This also removes the old style seeding configuration from version 1.0.0. (2011). This makes this PR a breaking change.

This also removes some quirky configuration for the sqlite seed test yaml file by manually waiting 1 second in the test.

And it does fix an error with remove_all and coverage, the reason why I investigated the whole thing in the first place.

Closes #927

@simonseyock simonseyock marked this pull request as draft November 19, 2024 08:20
@simonseyock simonseyock force-pushed the remove-all-coverages branch 3 times, most recently from b933cb3 to 42611bf Compare November 19, 2024 17:18
@simonseyock simonseyock marked this pull request as ready for review November 20, 2024 09:28
@simonseyock simonseyock merged commit 967dba8 into mapproxy:master Jan 23, 2025
6 checks passed
@simonseyock simonseyock deleted the remove-all-coverages branch January 23, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove_all does not remove cache

2 participants