fix: remove_all with coverages #1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
remove_timestampandbefore_timestampcould have 3 different kinds of values with different meanings. That made the code difficult to read and led to some errors. The possibilities were:{number}- an actual timestamp the tiles would be compared toNone- means that the tile should not be considered stale at any time0- means that the tile should be deleted/refreshed no matter whatI removed the
0meaning and addedremove_allandrefresh_allparameters that gets passed into every function where this check is performed. In my opinion that makes the code more understandable.It also adds a
handle_alloption to theTileWalkerwhich is used for more complex seeding and cleanup tasks. This option means that all existing tiles will be handled.This also removes the old style seeding configuration from version 1.0.0. (2011). This makes this PR a breaking change.
This also removes some quirky configuration for the sqlite seed test yaml file by manually waiting 1 second in the test.
And it does fix an error with
remove_allandcoverage, the reason why I investigated the whole thing in the first place.Closes #927