[release-0.26] Check the ClusterDomainClaim before creating kcert.
#12082
Conversation
I unfortunately ran afoul of a change in the default behavior where `DomainMapping` stopped creating `ClusterDomainClaim` by default, and I unfortunately had auto-TLS enabled, and before I could enable this creation, my Let's Encrypt quota for the week had been exhausted. It seems like the best course all around is to verify the domain has been claimed before we direct `kcert` to try provisioning a certificate, which will otherwise 404.
Codecov Report
@@ Coverage Diff @@
## release-0.26 #12082 +/- ##
=============================================
Coverage 87.55% 87.55%
=============================================
Files 196 196
Lines 9497 9497
=============================================
Hits 8315 8315
Misses 912 912
Partials 270 270
Continue to review full report at Codecov.
|
|
/retest |
|
/override pull-knative-serving-istio-stable-no-mesh Only the scale tests failed - thus this is hitting GKE 1.21 regression |
|
@dprotaso: Overrode contexts on behalf of dprotaso: pull-knative-serving-istio-stable-no-mesh In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #12080