Check the ClusterDomainClaim before creating kcert.
#12080
Conversation
I unfortunately ran afoul of a change in the default behavior where `DomainMapping` stopped creating `ClusterDomainClaim` by default, and I unfortunately had auto-TLS enabled, and before I could enable this creation, my Let's Encrypt quota for the week had been exhausted. It seems like the best course all around is to verify the domain has been claimed before we direct `kcert` to try provisioning a certificate, which will otherwise 404.
Codecov Report
@@ Coverage Diff @@
## main #12080 +/- ##
==========================================
- Coverage 87.48% 87.44% -0.05%
==========================================
Files 196 196
Lines 9534 9534
==========================================
- Hits 8341 8337 -4
- Misses 920 922 +2
- Partials 273 275 +2
Continue to review full report at Codecov.
|
|
Pretty sure the failure is a known flake. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.26 |
|
@julz: once the present PR merges, I will cherry-pick it on top of release-0.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.25 |
|
@julz: once the present PR merges, I will cherry-pick it on top of release-0.25 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.24 |
|
@julz: once the present PR merges, I will cherry-pick it on top of release-0.24 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.23 |
|
@julz: once the present PR merges, I will cherry-pick it on top of release-0.23 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@julz: new pull request created: #12082 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@julz: new pull request created: #12083 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@julz: new pull request created: #12084 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@julz: new pull request created: #12085 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I unfortunately ran afoul of a change in the default behavior where
DomainMappingstopped creatingClusterDomainClaimby default, andI unfortunately had auto-TLS enabled, and before I could enable this
creation, my Let's Encrypt quota for the week had been exhausted.
It seems like the best course all around is to verify the domain has
been claimed before we direct
kcertto try provisioning a certificate,which will otherwise 404.
cc @tcnghia (who I believe added this)
/assign @dprotaso @julz
FWIW, I believe that after this lands, we should
/cherrypickto supported releases.