这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

[release-1.5] [MT Scheduler] Deschedule placements on FinalizeKind #1207

Merged
merged 1 commit into from
Jul 6, 2022
Merged

[release-1.5] [MT Scheduler] Deschedule placements on FinalizeKind #1207

merged 1 commit into from
Jul 6, 2022

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1206

- Finalization of KafkaSource now calls the MT Scheduler to deschedule placements which causes proper cleanup of internal resources.

@aavarghese @knative-prow-robot
Deschedule placements on FinalizeKind
5f4cdd0 
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Jul 6, 2022
Merged
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022 •
edited
Loading

Codecov Report

Merging #1207 (5f4cdd0) into release-1.5 (d1bcd27) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.5    #1207   +/-   ##
============================================
  Coverage        74.91%   74.91%           
============================================
  Files              128      128           
  Lines             9011     9011           
============================================
  Hits              6751     6751           
  Misses            2029     2029           
  Partials           231      231

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1bcd27...5f4cdd0. Read the comment docs.

@aavarghese
Copy link
Contributor

/retest

aavarghese
aavarghese approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@aavarghese aavarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022
@lionelvillard
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, knative-prow-robot, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@knative-prow knative-prow bot merged commit b8d0ff0 into knative-extensions:release-1.5 Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aavarghese aavarghese aavarghese approved these changes

Assignees

@aavarghese aavarghese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-prow-robot @aavarghese @lionelvillard