这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2024. It is now read-only.

[MT Scheduler] Deschedule placements on FinalizeKind #1206

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Jul 5, 2022

Signed-off-by: aavarghese avarghese@us.ibm.com

Fixes #1208
IBM Code Engine stress testing discovered issue with KafkaSource where resources don't get cleaned up causing scheduling to get stuck (flip floping from True to False ready states after 15+ hours)
Related to knative/eventing#6440

Proposed Changes

  • Finalization of KafkaSource now calls the MT Scheduler to deschedule placements which causes proper cleanup of internal resources.

Release Note

Finalization of KafkaSource now calls the MT Scheduler to deschedule placements which causes proper cleanup of internal resources.

Signed-off-by: aavarghese <avarghese@us.ibm.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2022
@aavarghese
Copy link
Contributor Author

/cherry-pick release-1.5

@knative-prow-robot
Copy link
Contributor

@aavarghese: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1206 (240dce8) into main (b615fa7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files         128      128           
  Lines        9011     9011           
=======================================
  Hits         6751     6751           
  Misses       2029     2029           
  Partials      231      231           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b615fa7...240dce8. Read the comment docs.

@cr22rc
Copy link

cr22rc commented Jul 6, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2022
@cr22rc
Copy link

cr22rc commented Jul 6, 2022

/approve

@cr22rc
Copy link

cr22rc commented Jul 6, 2022

/retest

@lionelvillard
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Jul 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, cr22rc, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2022
@knative-prow knative-prow bot merged commit ed44127 into knative-extensions:main Jul 6, 2022
@knative-prow-robot
Copy link
Contributor

@aavarghese: new pull request created: #1207

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaSource in a scheduling loop after hours of stress testing
4 participants