这是indexloc提供的服务，不要输入任何密码
Skip to content

Fixed bug, added German variants. #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 29, 2018
Merged

Fixed bug, added German variants. #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0c1ed5
Fixed bug, added German variants.
SrzStephen Mar 29, 2018
5a137ab
Cultural inclusiveness
SrzStephen Mar 29, 2018
bd4ac20
Minor fix
SrzStephen Mar 29, 2018
bb5e20d
Added tests
SrzStephen Mar 29, 2018
04fd464
Fixed failing test
SrzStephen Mar 29, 2018
e8d2184
semicolon missing
SrzStephen Mar 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion consts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,16 @@ var thirteenStrings = [
"13i",

// B just looks like 13 written closer
"b",
"B",
//For cultural inclusiveness also include German variants
"ß",
"ẞ",
//Also greek
"β",
"Β", //actually upper case Beta, not B
//And Chinese
"阝", //(Kangxi radical)


//Adding "l" 3, "i"3, |3 and !3 because they basically look like thirteen
"i3",
Expand Down
11 changes: 7 additions & 4 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ tap.equal(is("PT").thirteen(), true);
tap.equal(is("Washington Luís").thirteen(), true);
tap.equal(is("Millard Fillmore").thirteen(), true);
//year of birth test
tap.equal(is("2003").yearOfBirth(), true)
tap.equal(is("2003").yearOfBirth(), false);

// Imaginary 13's tests
tap.equal(is("13+0i").thirteen(), true);
Expand Down Expand Up @@ -163,9 +163,12 @@ tap.equal(is("quainel").thirteen(), true); // Quenya
tap.equal(is("mînuiug").thirteen(), true); // Sindarin

tap.equal(is("B").thirteen(), true); // B looks like 13
tap.equal(is("b").thirteen(), true); // b looks like 13 when upper case

tap.equal(is("β").thirteen(), true); // β looks like 13
tap.equal(is("b").thirteen(), false); // b does not look like 13
tap.equal(is("ß").thirteen(), true); // German: looks like 13
tap.equal(is("ẞ").thirteen(), true); // German: looks like 13
tap.equal(is("Β").thirteen(), true); // Upper case beta, looks like 13
tap.equal(is("β").thirteen(), true); // lower case beta
tap.equal(is("阝").thirteen(), true); // Chinese Kangxi radical: Looks like 13

tap.equal(is("i3").thirteen(),true); //i3 looks like 13 when upper case
tap.equal(is("I3").thirteen(),true); //I3 looks like 13
Expand Down