Fixed bug, added German variants. #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous comment:
---
// B just looks like 13 written closer
"b",
----
b looks nothing like 13, if this is allowed to stay in then the integrity of this package is compromised as this is erroneous behaviour that I will have to catch if I truly want to see if something is 13. I have replaced it with the upper case B, and added the German ß and ẞ because it's 2018 - it's important to be inclusive of other cultures and they kinda look like a 13 if you have bad handwriting.
Added Greek and Chinese variants
Added tests for the additional 13s. Test for b returns false now, because b does not look like 13
If 2003 is year of birth that would be 15 not 13.
Contributor
Author
|
This ended up being a slightly bigger patch than i'd anticipated. |
Collaborator
|
Looks great, thanks for your contribution to our glorious nation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Failing test (Year of Birth). Now 100% of tests are passing
Removed incorrect entry (lower case b), and added other "look like 13 but mashed together" entries from the German, Greek and Chinese alphabets.
Added tests for the entries that I added.