feat: support chromium-based Micorsoft Edge #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directory structure is similar to chrome
Directory structure is similar to chrome
…into edge_more_platform
Because the keychain was written to death, I don't want to destroy the original code.
Additional Realizations
chrome and edge get a different Safe Storage
reuse chrome's code
kalifun
approved these changes
Feb 25, 2023
kalifun
left a comment
There was a problem hiding this comment.
After you changed it, you circled me back. I wanted to do this before. But because of the file name of chrome, I was in a dilemma. That's why it is independent.
If it is more perfect, maybe it should be renamed chromium.
But there is too much dependence. Maybe it is a better solution at present.
kalifun
reviewed
Feb 25, 2023
| case `chrome`: | ||
| service = `Chrome Safe Storage` | ||
| account = `Chrome` | ||
| case `chromium`: |
There was a problem hiding this comment.
I haven't tried it, but I understand that they are all based on chromium and their principles should be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2, thanks @kalifun