这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: Edge support more platform #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

feat: Edge support more platform #2

wants to merge 9 commits into from

Conversation

@kalifun
Copy link

@kalifun kalifun commented Feb 9, 2023

Currently cookies are stored in the same way as the Chrome browser stores them.

so, reuse chrome's code

Platform:

  • Mac
  • Win

@kalifun
🚧 Mac edge support
c6c30c1 
Directory structure is similar to chrome
@kalifun
🚧 Mac edge support
0e5bb31 
Directory structure is similar to chrome
@kalifun
Merge branch 'edge_more_platform' of https://github.com/kalifun/kooky …
67bb53f 
…into edge_more_platform
@kalifun
🚨 remove error
b59e092
@kalifun
💥 Implementation of reuse of chrome
44e9e56 
Because the keychain was written to death, I don't want to destroy the original code.
@kalifun
Create edge_windows.go
7e97173 
Additional Realizations
@kalifun
Update chrome_darwin_cgo.go
ee7e91e 
chrome and edge get a different Safe Storage
@kalifun
removing duplicate logic
ea43877 
reuse chrome's code
@kalifun
Copy link
Author

kalifun commented Feb 16, 2023

Hope this submission can be merged

This repo only implemented windows version and did not support MacOs.

@j178
Copy link
Owner

j178 commented Feb 23, 2023

Sorry, I don't know why GitHub never notified this PR to me, sorry for the delay! Will take a look as soon as possible, thank you.

@kalifun
Copy link
Author

kalifun commented Feb 23, 2023

Sorry, I don't know why GitHub never notified this PR to me, sorry for the delay! Will take a look as soon as possible, thank you.

It doesn't matter. I hope some of the problems can be solved.

@j178 j178 mentioned this pull request Feb 24, 2023
Merged
@j178
Copy link
Owner

j178 commented Feb 24, 2023

Hi @kalifun, thank you very much for your work.

I made some modifications based on your commits, but for some reason, GitHub does not allow me to add a commit to your branch.
image

Therefore, I have created a new pull request based on your work #4. Would you please be able to review it?

@kalifun
Copy link
Author

kalifun commented Feb 24, 2023

Hi @kalifun, thank you very much for your work.

I made some modifications based on your commits, but for some reason, GitHub does not allow me to add a commit to your branch. image

Therefore, I have created a new pull request based on your work #4. Would you please be able to review it?

I'm very sorry. Working overtime today. I'll deal with it tomorrow.

@j178
Copy link
Owner

j178 commented Feb 25, 2023

Thanks, #4 has been merged, I'll create a PR on https://github.com/j178/leetgo to bump the version. I'll close this as completed.

@j178 j178 closed this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalifun @j178