这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fpena
Copy link
Contributor

@fpena fpena commented May 2, 2025

Description

adds react-native-edge-to-edge - https://expo.dev/blog/edge-to-edge-display-now-streamlined-for-android

Checklist

  • README.md and other relevant documentation has been updated with my changes
  • I have manually tested this, including by generating a new app locally (see docs).

@fpena fpena changed the title Fpena/support react native edge to edge [DRAFT] Fpena/support react native edge to edge May 2, 2025
@fpena fpena force-pushed the fpena/support-react-native-edge-to-edge branch from f1941cf to c2085a9 Compare May 28, 2025 18:11
@markrickert markrickert changed the base branch from master to feat/expo-sdk-53 May 31, 2025 01:03
@markrickert markrickert force-pushed the fpena/support-react-native-edge-to-edge branch from c2085a9 to 484acc0 Compare May 31, 2025 01:03
@markrickert markrickert marked this pull request as ready for review May 31, 2025 01:07
@markrickert markrickert changed the title [DRAFT] Fpena/support react native edge to edge feat: add react-native-edge-to-edge support May 31, 2025
Copy link
Contributor

@frankcalise frankcalise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried out these changes in my side project app and worked well!

EDIT:

As a follow up, I wanted to hide the navigationBar when a Bottom Sheet was open so the sheet didn't have a break at the bottom. This worked by setting systemBars hidden prop, but upon returning to the home screen say, the tab bar was then a little messed up.

I'm curious how to do this correctly - I'll make a smaller repro of it to see if it's just my side project or the library. I don't think it has to do with these changes, to be clear.

@markrickert markrickert mentioned this pull request Jun 3, 2025
8 tasks
Copy link
Member

@markrickert markrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried this on an android build an it looks good!

@markrickert markrickert force-pushed the fpena/support-react-native-edge-to-edge branch from 484acc0 to cbe1623 Compare June 23, 2025 23:34
@markrickert markrickert merged commit 3e86044 into feat/expo-sdk-53 Jun 23, 2025
1 check passed
@markrickert markrickert deleted the fpena/support-react-native-edge-to-edge branch June 23, 2025 23:40
@frankcalise frankcalise linked an issue Jun 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Implement react-native-edge-to-edge

4 participants