-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add react-native-edge-to-edge support #2937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add react-native-edge-to-edge support #2937
Conversation
f1941cf to
c2085a9
Compare
c2085a9 to
484acc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried out these changes in my side project app and worked well!
EDIT:
As a follow up, I wanted to hide the navigationBar when a Bottom Sheet was open so the sheet didn't have a break at the bottom. This worked by setting systemBars hidden prop, but upon returning to the home screen say, the tab bar was then a little messed up.
I'm curious how to do this correctly - I'll make a smaller repro of it to see if it's just my side project or the library. I don't think it has to do with these changes, to be clear.
markrickert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried this on an android build an it looks good!
484acc0 to
cbe1623
Compare
Description
adds react-native-edge-to-edge - https://expo.dev/blog/edge-to-edge-display-now-streamlined-for-android
Checklist
README.mdand other relevant documentation has been updated with my changes