fix(cli): catch expo install --fix tripping test #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolsoftwaretyler
approved these changes
Nov 24, 2024
Contributor
coolsoftwaretyler
left a comment
There was a problem hiding this comment.
LGTM! Let's keep thinking about this. I am always down to brainstorm about Ignite stuff if you want to talk through other options for the long term.
frankcalise
added a commit
that referenced
this pull request
Nov 24, 2024
[skip ci] * fix: spelling and small updates * fix(cli): catch expo install --fix tripping test (#2852) [skip ci] * fix(cli): catch expo install --fix tripping test * fix(boilerplate): reactotron caret dep * fix(cli): add debug log for expo install fix * fix(cli): document skipping --fix on ci * fix(cli): log expo install --fix output --------- Co-authored-by: Frank Calise <fcalise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantyarn linteslint checks pass with new code, if relevantyarn format:checkprettier checks pass with new code, if relevantREADME.md(or relevant documentation) has been updated with your changesDescribe your PR
npx expo install --fix, which is part of the new command, causes tests to fail due to it's console output