这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(cli): catch expo install --fix tripping test #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 24, 2024
Merged

fix(cli): catch expo install --fix tripping test #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9317f7
fix(cli): catch expo install --fix tripping test
frankcalise Nov 23, 2024
813de60
fix(boilerplate): reactotron caret dep
frankcalise Nov 23, 2024
4eb0f71
fix(cli): add debug log for expo install fix
frankcalise Nov 23, 2024
a7fba30
fix(cli): document skipping --fix on ci
frankcalise Nov 24, 2024
c2c7d8e
fix(cli): log expo install --fix output
frankcalise Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion boilerplate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"postinstall-prepare": "1.0.1",
"prettier": "^3.3.3",
"react-test-renderer": "18.2.0",
"reactotron-core-client": "2.9.4",
"reactotron-core-client": "^2.9.4",
"reactotron-mst": "^3.1.7",
"reactotron-react-js": "^3.3.11",
"reactotron-react-native": "^5.0.5",
Expand Down
9 changes: 7 additions & 2 deletions src/commands/new.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,8 +756,13 @@ module.exports = {
await system.run(`npm install ajv@^8 --legacy-peer-deps`, { onProgress: log })
}
// now that expo is installed, we can run their install --fix for best Expo SDK compatibility
const forwardOptions = packagerName === "npm" ? " -- --legacy-peer-deps" : ""
await system.run(`npx expo install --fix${forwardOptions}`, { onProgress: log })
// for right now, we don't do this in CI because it returns a non-zero exit code
// see https://docs.expo.dev/more/expo-cli/#version-validation
if (process.env.CI !== "true") {
const forwardOptions = packagerName === "npm" ? " -- --legacy-peer-deps" : ""
log("Running `npx expo install --fix...`")
await system.run(`npx expo install --fix${forwardOptions}`, { onProgress: log })
}

stopSpinner(unboxingMessage, "🧶")
}
Expand Down