-
Notifications
You must be signed in to change notification settings - Fork 139
Use createNativeStackNavigator from react-native-screens #330
Use createNativeStackNavigator from react-native-screens #330
Conversation
…avigation is deprecated
|
Thanks @harrisrobin ! <3 |
## [5.0.1](v5.0.0...v5.0.1) (2020-04-13) ### Bug Fixes * **navigation:** Use createNativeStackNavigator from react-native-screens ([#330](#330) by [@harrisrobin](https://github.com/harrisrobin)) ([044f661](044f661))
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
i dont know the reason but on some android device, it make slow and lag when the first time app open. I have moved to @react-navigation/stack it's work fine. I tested on sony xzs android 8 |
|
Yeah, it might make sense to only use the native stack on iOS and use the non-native on Android. @harrisrobin did that, I think? |
Yes that’s what I ended up doing but I also haven’t tested the latest versions of react-native-screens. Might be worth upgrading that and see if it improves android perf before you do so. Otherwise, i would export JS stack for android. I usually create a little helper function to handle that so the changes are minimal when switching between the two. E.G: const createStack = Platform.select({
ios: createNativeStackNavigator,
android: createStackNavigator
})Haven't tested this code and just wrote it quickly, but that's what I'd expect it to look like. |
This PR uses
createNativeStackNavigatorfrom react-native-screens instead of@react-navigation/native(now deprecated and moved to react-native-screens).