这是indexloc提供的服务,不要输入任何密码
Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@harrisrobin
Copy link
Contributor

This PR uses createNativeStackNavigator from react-native-screens instead of @react-navigation/native (now deprecated and moved to react-native-screens).

@jamonholmgren jamonholmgren merged commit 044f661 into infinitered:master Apr 13, 2020
@jamonholmgren
Copy link
Member

Thanks @harrisrobin ! <3

infinitered-circleci pushed a commit that referenced this pull request Apr 13, 2020
## [5.0.1](v5.0.0...v5.0.1) (2020-04-13)

### Bug Fixes

* **navigation:** Use createNativeStackNavigator from react-native-screens  ([#330](#330) by [@harrisrobin](https://github.com/harrisrobin)) ([044f661](044f661))
@infinitered-circleci
Copy link
Collaborator

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vantuan88291
Copy link

i dont know the reason but on some android device, it make slow and lag when the first time app open. I have moved to @react-navigation/stack it's work fine. I tested on sony xzs android 8

@jamonholmgren
Copy link
Member

Yeah, it might make sense to only use the native stack on iOS and use the non-native on Android. @harrisrobin did that, I think?

@harrisrobin
Copy link
Contributor Author

harrisrobin commented May 6, 2020

Yeah, it might make sense to only use the native stack on iOS and use the non-native on Android. @harrisrobin did that, I think?

Yes that’s what I ended up doing but I also haven’t tested the latest versions of react-native-screens. Might be worth upgrading that and see if it improves android perf before you do so. Otherwise, i would export JS stack for android. I usually create a little helper function to handle that so the changes are minimal when switching between the two.

E.G:

const createStack = Platform.select({
 ios: createNativeStackNavigator,
 android: createStackNavigator
})

Haven't tested this code and just wrote it quickly, but that's what I'd expect it to look like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants