Fix client side flash when navigating #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Does it prevent the memory leak (seems it's still there)? Just wondering as I've looked at this fix myself last week (saw how it was done in LiveVue) but couldn't reproduce the memory leak locally. There's also an indication that the memory leak is caused by the Elixir node library so I'm fine with merging this. |
Contributor
Author
|
I made sure the components get destroyed properly and monitored the memory tab for a couple hours and could not replicate the slight spike in memory that I previously could. So I (perhaps incorrectly) assumed that the memory leak is still fixed. Happy to be wrong though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #125 while still preventing memory leak.