这是indexloc提供的服务,不要输入任何密码
Skip to content

Fix client side flash when navigating #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

louis-smit
Copy link
Contributor

Fix for issue #125 while still preventing memory leak.

@woutdp
Copy link
Owner

woutdp commented May 21, 2024

Does it prevent the memory leak (seems it's still there)? Just wondering as I've looked at this fix myself last week (saw how it was done in LiveVue) but couldn't reproduce the memory leak locally. There's also an indication that the memory leak is caused by the Elixir node library so I'm fine with merging this.

@woutdp woutdp merged commit 72be602 into woutdp:master May 21, 2024
@louis-smit
Copy link
Contributor Author

I made sure the components get destroyed properly and monitored the memory tab for a couple hours and could not replicate the slight spike in memory that I previously could. So I (perhaps incorrectly) assumed that the memory leak is still fixed. Happy to be wrong though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants