Avoid iOS crash at all cost #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow to skip some part of events (during serialization) that leave an NSLog and also add try/catch with reject for most method that present a risk. This helped me recover errors from JavaScript instead of facing a brutal crash.
wmcmahan
reviewed
Jul 30, 2020
wmcmahan
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to skip some part of events (during serialization) that leave an NSLog and also add try/catch with reject for most method that present a risk.
This helped me recover errors from JavaScript instead of facing a brutal crash.
@wmcmahan I am very new to objective-c & would like your input on this (asking since I saw you handled some issues yay!)
Better to review without whitespace changes!
Note that this PR is on branch 2.0.0 (I am preparing a release with latest changes that are in master, unreleased, and some others that I tried on the 2.0.0 branch)
Also, should we do something similar for Android or is the way async is handled (from JS) enough to trigger promise rejection if something fails native side?)
Closes #311
Closes #281