Fixed iOS null event crash issue #311
Conversation
|
Please merge this |
| CGFloat r = components[0]; | ||
| CGFloat g = components[1]; | ||
| CGFloat b = components[2]; | ||
|
|
There was a problem hiding this comment.
Are you sure about this change?
This seems more defensive programming that could be legit (I didn't check the git history to find out)
| } | ||
|
|
||
| NSURL *URL = [NSURL URLWithString:[url stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLQueryAllowedCharacterSet]]]; | ||
| NSURL *URL = [NSURL URLWithString:[url stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]]]; |
There was a problem hiding this comment.
We recently made a fix somewhere, are you also sure about this change?
| NSDictionary * sCalendarEvent = [self serializeCalendarEvent:event]; | ||
| if(sCalendarEvent != nil){ | ||
| [serializedCalendarEvents addObject:sCalendarEvent]; | ||
| } |
There was a problem hiding this comment.
This look like it's the fix you want to push?
| return [formedCalendarEvent copy]; | ||
| } @catch (NSException *exception) { | ||
| return nil; | ||
| } |
There was a problem hiding this comment.
I am not familiar is iOS code, but this look like it's not that safe to return nil.
What is the goal of this? How does JS should behave with this change?
| [formedCalendarEvent setValue:[self availabilityStringMatchingConstant:event.availability] forKey:_availability]; | ||
|
|
||
| if (event.structuredLocation && event.structuredLocation.title && event.structuredLocation.radius) { | ||
| if (event.structuredLocation) { |
There was a problem hiding this comment.
Any reason you remove some safety tests?
| if (event.calendar) { | ||
| [formedCalendarEvent setValue:@{ | ||
| @"id": event.calendar.calendarIdentifier?event.calendar.calendarIdentifier: @"tempCalendar", | ||
| @"id": event.calendar.calendarIdentifier, |
There was a problem hiding this comment.
Could you explain me this change please?
| return resolve(@(success)); | ||
| }); | ||
| } | ||
|
|
| resolve(sCalendarEvent); | ||
| }else{ | ||
| resolve(@[]); | ||
| } |
| }else{ | ||
| reject(@"error", @"error finding event", nil); | ||
| } | ||
|
|
There was a problem hiding this comment.
How does the behave without this change?
|
It seems you reverted 4cb815b without paying attention :) |
No description provided.