这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: Implement new metrics endpoint for k8s 1.24+ #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 28, 2023
Merged

feat: Implement new metrics endpoint for k8s 1.24+ #1082

merged 12 commits into from
Mar 28, 2023

Conversation

fnuarnav
Copy link
Contributor

@fnuarnav fnuarnav commented Mar 7, 2023 •
edited by pires
Loading

Added handlers for /metrics/resource endpoint

Refs #1075

Closes #987

@helayoty helayoty requested review from pires, helayoty and cpuguy83 March 9, 2023 18:33
pires
pires reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@pires pires left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM but can you check why e2e fails?

--- FAIL: TestEndToEnd (7.87s)
    suite.go:62: True
    --- FAIL: TestEndToEnd/TestGetMetricsResource (0.80s)
        basic.go:139: the server could not find the requested resource (get pods https:vkubelet-mock-0:10250)
FAIL

@pires pires changed the title Fnuarnav/new metrics server endpoint Introduce new metrics server endpoint Mar 13, 2023
@pires pires changed the title Introduce new metrics server endpoint Introduce new metrics endpoint Mar 13, 2023
This was referenced Mar 16, 2023
Closed
Merged
@helayoty helayoty changed the title Introduce new metrics endpoint feat: Implement new metrics endpoint for k8s 1.24+ Mar 16, 2023
@fnuarnav fnuarnav requested review from pires and removed request for cpuguy83 and helayoty March 23, 2023 23:42
pires
pires approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pires
pires reviewed Mar 28, 2023
View reviewed changes
@pires pires force-pushed the fnuarnav/new-metrics-server-endpoint branch from 9de953f to 46b8c94 Compare March 28, 2023 11:49
@pires pires enabled auto-merge (squash) March 28, 2023 11:49
@pires pires merged commit a457d44 into virtual-kubelet:master Mar 28, 2023
@helayoty helayoty added this to the v1.9 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pires pires pires approved these changes

Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fnuarnav @pires @helayoty