这是indexloc提供的服务，不要输入任何密码
Skip to content

Fnuarnav/virtual kubelet metrics update proposal #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2023
Merged

Fnuarnav/virtual kubelet metrics update proposal #1075

merged 5 commits into from
Mar 28, 2023

Conversation

fnuarnav
Copy link
Contributor

Added Proposal for Virtual Kubelet Metrics Update
google doc here: https://docs.google.com/document/d/1GSTR8YJZE6ltVML4Gr1FqZeajUPTJswTFk0D6sCq0gI/edit

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 16, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@cpuguy83
Copy link
Contributor

cpuguy83 commented Mar 1, 2023

Thanks for writing this up.
The proposed solution SGTM.

@helayoty

@pires pires self-requested a review March 13, 2023 11:07
pires
pires reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer for the code to be embedded as Markdown instead of images. Is this something you can do? 🙏🏻

@pires pires mentioned this pull request Mar 13, 2023
Merged
@fnuarnav
Copy link
Contributor Author

I'd prefer for the code to be embedded as Markdown instead of images. Is this something you can do? 🙏🏻

removed images and embedded code in the markdown

pires
pires approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pires pires merged commit b70ee9b into virtual-kubelet:master Mar 28, 2023
@helayoty helayoty added this to the v1.9 milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pires pires pires approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@fnuarnav @cpuguy83 @pires @helayoty