-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: exports for eslint-config-turbo
#9978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
866ec51
fix: create types for ESLint config/plugin
anthonyshew fdba234
WIP
anthonyshew 7f1f40e
WIP
anthonyshew 08eca16
WIP
anthonyshew 4fecbd5
WIP
anthonyshew c656514
fix: exports for eslint-config-turbo
anthonyshew b87e478
WIP
anthonyshew 2b1c82d
WIP
anthonyshew 4ff684a
WIP
anthonyshew 408b086
WIP
anthonyshew 4374ef3
WIP
anthonyshew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| // eslint-disable-next-line import/no-default-export -- Matching old module.exports | ||
| export default { | ||
| extends: ["plugin:turbo/recommended"], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| { | ||
| "extends": "@turbo/tsconfig/library.json", | ||
| "compilerOptions": { | ||
| "rootDir": "." | ||
| "outDir": "dist" | ||
| }, | ||
| "include": ["src"], | ||
| "exclude": ["dist"] | ||
| } |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if this is the wrong spot for this, but it helped resolve an issue. When I upgraded from turbo@2.4.2 to 2.4.4 my eslint config broke while following the listed docs for legacy usage.
I updated to use this files
extendsand my eslint config was resolved.Old:
Resulted in:
Should the docs be updated to suggest using this instead?
New:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for tagging @anthonyshew, because this is important for people that not using eslint flat config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries. Thanks for the tag. Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the fix: #10105
Sorry about that!