fix: exports for eslint-config-turbo
#9978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eslint-config-turbo
tknickman
reviewed
Feb 14, 2025
joshnuss
pushed a commit
to joshnuss/turborepo
that referenced
this pull request
Feb 15, 2025
### Description Mis-mapped the exports conditions in package.json. 🤦
tony-cocco
reviewed
Feb 27, 2025
There was a problem hiding this comment.
Sorry if this is the wrong spot for this, but it helped resolve an issue. When I upgraded from turbo@2.4.2 to 2.4.4 my eslint config broke while following the listed docs for legacy usage.
I updated to use this files extends and my eslint config was resolved.
Old:
extends: ["turbo"]
Resulted in:
eslint-config-turbo is invalid:
- Unexpected top-level property "default".
Should the docs be updated to suggest using this instead?
New:
extends: ["plugin:turbo/recommended"]
There was a problem hiding this comment.
sorry for tagging @anthonyshew, because this is important for people that not using eslint flat config
There was a problem hiding this comment.
No worries. Thanks for the tag. Will fix.
There was a problem hiding this comment.
Here's the fix: #10105
Sorry about that!
trunk-io bot
pushed a commit
to arcjet/arcjet-js
that referenced
this pull request
Mar 4, 2025
This includes the turbo plugin correctly following [this comment](vercel/turborepo#9978 (comment)) from a user experiencing the same issue we encountered in #3337
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mis-mapped the exports conditions in package.json. 🤦