这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@shnjd
Copy link
Contributor

@shnjd shnjd commented Feb 2, 2025

Description

Updated Expo SDK to 51 and added expo router with file-based routing setup.
Updated dependencies to match expo sdk requirements.
Changed TouchableOpacity to Pressable in the packages/ui as the former is deprecated.

Testing Instructions

Changes can be verified by running dev script.
I've tested both Expo Go and development build (with JDK 17) for native app and nextjs's usual working.

shinjith-dev added 5 commits February 2, 2025 18:21
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
TouchableOpacity is now deprecated

Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd shnjd requested a review from a team as a code owner February 2, 2025 14:11
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage labels Feb 2, 2025
@vercel
Copy link
Contributor

vercel bot commented Feb 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm

@vercel
Copy link
Contributor

vercel bot commented Feb 2, 2025

@shinjith-dev is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) February 3, 2025 21:44
@anthonyshew anthonyshew merged commit 4058882 into vercel:main Feb 3, 2025
31 checks passed
@shnjd
Copy link
Contributor Author

shnjd commented Mar 16, 2025

@anthonyshew Small issue here; @types/react-native is no longer needed as the react-native is typed since version 0.71. The package has metro-* packages as peer deps which might create issues (I recently had issues due to this but the error message was not really helpful). We just need to remove this package from apps/native and packages/ui of this example. Sorry for not running thorough tests. Should I create a PR, or can you handle it? Has attached the expo doctor result for clarification. Thanks.
Screenshot_2025-03-16_14-58-49

@anthonyshew
Copy link
Contributor

A PR would be great! Thank you!

@shnjd
Copy link
Contributor Author

shnjd commented Mar 17, 2025

Done #10190

anthonyshew pushed a commit that referenced this pull request Mar 18, 2025
…ive-web (#10190)

Removed obsolete `@types/react-native` as it has peer deps that might
break expo/metro version compatibility and no longer needed.

### Description

Resolved issues ([mentioned
here](#9872 (comment)))
due to the use of obsolete types package.


![Screenshot_2025-03-17_23-55-52](https://github.com/user-attachments/assets/b429ad5c-3c93-4d76-96c7-c85eb4424ff5)

Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: examples Improvements or additions to examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants