这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(example): update with-react-native-web, Expo SDK 51 & Expo Router (File-based routing) #9872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 3, 2025
Merged

feat(example): update with-react-native-web, Expo SDK 51 & Expo Router (File-based routing) #9872

merged 7 commits into from
Feb 3, 2025

Conversation

shnjd
Copy link
Contributor

@shnjd shnjd commented Feb 2, 2025

Description

Updated Expo SDK to 51 and added expo router with file-based routing setup.
Updated dependencies to match expo sdk requirements.
Changed TouchableOpacity to Pressable in the packages/ui as the former is deprecated.

Testing Instructions

Changes can be verified by running dev script.
I've tested both Expo Go and development build (with JDK 17) for native app and nextjs's usual working.

shnjd added 5 commits February 2, 2025 18:21
@shnjd
fix: change dev script to expo start
4b2c640 
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd
fix: dependency fix & sync using expo install --fix
28888bc 
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd
chore: bump expo to 50 & Pressable instead of TouchableOpacity
0cca030 
TouchableOpacity is now deprecated

Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd
chore: bump expo to 51
5686a2d 
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd
feat: add & setup expo-router, clean up
7ed0b94 
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd shnjd requested a review from a team as a code owner February 2, 2025 14:11
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage labels Feb 2, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:41pm

@vercel Vercel
Copy link

vercel bot commented Feb 2, 2025

@shinjith-dev is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@shnjd
fix: changed native:dev script back to expo start --web
04f905b 
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
@shnjd shnjd changed the title Expo SDK 51 & App Router (File-based routing) Expo SDK 51 & Expo Router (File-based routing) Feb 2, 2025
@shnjd shnjd changed the title Expo SDK 51 & Expo Router (File-based routing) feat(example): update with-react-native-web, Expo SDK 51 & Expo Router (File-based routing) Feb 2, 2025
@shnjd
fix: change back scripts modified while testing dev build
492a52f 
Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
anthonyshew
anthonyshew approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anthonyshew anthonyshew enabled auto-merge (squash) February 3, 2025 21:44
@anthonyshew anthonyshew merged commit 4058882 into vercel:main Feb 3, 2025
31 checks passed
This was referenced Feb 25, 2025
Merged
Merged
@renovate renovate bot mentioned this pull request Mar 11, 2025
Open
1 task
@shnjd
Copy link
Contributor Author

shnjd commented Mar 16, 2025 •
edited
Loading

@anthonyshew Small issue here; @types/react-native is no longer needed as the react-native is typed since version 0.71. The package has metro-* packages as peer deps which might create issues (I recently had issues due to this but the error message was not really helpful). We just need to remove this package from apps/native and packages/ui of this example. Sorry for not running thorough tests. Should I create a PR, or can you handle it? Has attached the expo doctor result for clarification. Thanks.
Screenshot_2025-03-16_14-58-49

@anthonyshew
Copy link
Contributor

A PR would be great! Thank you!

@shnjd
Copy link
Contributor Author

shnjd commented Mar 17, 2025

Done #10190

@shnjd shnjd mentioned this pull request Mar 17, 2025
Merged
anthonyshew pushed a commit that referenced this pull request Mar 18, 2025
@shnjd
fix(example): remove obsolete @types/react-native from with-react-nat…
bfc50ac 
…ive-web (#10190)

Removed obsolete `@types/react-native` as it has peer deps that might
break expo/metro version compatibility and no longer needed.

### Description

Resolved issues ([mentioned
here](#9872 (comment)))
due to the use of obsolete types package.


![Screenshot_2025-03-17_23-55-52](https://github.com/user-attachments/assets/b429ad5c-3c93-4d76-96c7-c85eb4424ff5)

Signed-off-by: shinjith-dev <shinjithpallikkara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shnjd @anthonyshew