这是indexloc提供的服务，不要输入任何密码
Skip to content

Implement --dry-run, formerly --plan #862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 11, 2022
Merged

Implement --dry-run, formerly --plan #862

merged 14 commits into from
Mar 11, 2022

Conversation

@gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Mar 10, 2022 •
edited by jaredpalmer
Loading

Close #380

  • Split up different run modes in run.go
  • Update the scheduler to move the task-to-be-run to Execute rather than AddTask. This lets us construct the graph before deciding what to do with it, as well as leaving open the option of multiple passes.
  • Implement --dry-run[=json]. Outputs packages in scope, as well as tasks to be run.

@vercel
Copy link
Contributor

vercel bot commented Mar 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/AndRYuG16oJVsUqAjVe5PJqNX8nR
✅ Preview: https://turbo-site-git-gsoltis-dryrun.vercel.sh

Greg Soltis added 3 commits March 10, 2022 13:32
Move visitor to Execute on scheduler, rather than the task itself. Al…
dc5c663 
…lows reuse of the graph. Split out the execution task, as well as the dot graph function
Extract building the engine
475a12a
Add JSON functionality
6f9b13c
@gsoltis gsoltis marked this pull request as ready for review March 10, 2022 21:39
jaredpalmer
jaredpalmer suggested changes Mar 10, 2022
View reviewed changes
@jaredpalmer jaredpalmer changed the title Implement --dry-run Implement --dry-run, formerly --plan Mar 10, 2022
@gsoltis gsoltis mentioned this pull request Mar 11, 2022
Closed
@weyert
Copy link
Contributor

weyert commented Mar 11, 2022

Can't wait to try this out with GitLab CI :D

@jaredpalmer jaredpalmer added the pr: automerge Kodiak will merge these automatically after checks pass label Mar 11, 2022
@jaredpalmer
Copy link
Contributor

jaredpalmer commented Mar 11, 2022

We'll do docs next week.

@kodiakhq kodiakhq bot merged commit 5292efb into main Mar 11, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/dry_run branch March 11, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaspar09 gaspar09 Awaiting requested review from gaspar09

1 more reviewer

@jaredpalmer jaredpalmer jaredpalmer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: automerge Kodiak will merge these automatically after checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gsoltis @weyert @jaredpalmer