-
Notifications
You must be signed in to change notification settings - Fork 2k
Adds the plan
command
#846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/5fPGSA6xr7TDBitcDaDKcxKZoCfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should make this a flag on run
? If we think about what we would need to use --plan
to clean up e2e tests, I think we would need payload of package in scope, task ids + hashes. What do you think?
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking promising
@weyert serialized graph is a different matter which we are going to support. The goal here is to increase observability and unblock folks using |
@jaredpalmer re: cleaning up e2e tests, I think we need to be able to check "packages in scope", "tasks to be run", and "what was run from cache". As currently implemented, I'm not sure I have a strong opinion on a separate command vs flag to |
As a user I think I'd prefer |
Agree with @alexandernanberg —dry makes sense. Obvs let’s keep the abstraction needed to get the graph and scope outside of run command. These will be useful for the query commands we chatted about in our sync yesterday. |
I think |
Closing in favor of #862 |
turbo run
with equivalent arguments--json
flag to produce output as a pretty-printed json array