这是indexloc提供的服务，不要输入任何密码
Skip to content

Revert "add support for dynamic requests in require() and import()" #7397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

Revert "add support for dynamic requests in require() and import()" #7397

merged 1 commit into from
Feb 15, 2024

Conversation

@sokra
Copy link
Member

@sokra sokra commented Feb 15, 2024 •
edited by padmaia
Loading

Reverts #7153

Closes PACK-2511

@sokra sokra requested a review from a team as a code owner February 15, 2024 08:43
@vercel
Copy link
Contributor

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
examples-native-web 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
examples-nonmonorepo 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
examples-svelte-web 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
examples-tailwind-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 8:43am
examples-vite-web 🔄 Building (Inspect) Visit Preview Feb 15, 2024 8:43am
rust-docs ❌ Failed (Inspect) Feb 15, 2024 8:43am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 8:43am
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 8:43am

@linear
Copy link

linear bot commented Feb 15, 2024

Issue reopened: PACK-986 Support dynamic expressions in require

@sokra sokra merged commit f6e432b into main Feb 15, 2024
@sokra sokra deleted the revert-7153-sokra/dynamic-request branch February 15, 2024 08:43
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

sokra added a commit that referenced this pull request Feb 15, 2024
@sokra
Revert "Revert "add support for dynamic requests in require() and imp…
b67f2c5 
…ort()" (#7397)"

This reverts commit f6e432b.
@pixelchutes pixelchutes mentioned this pull request May 1, 2024
Closed
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
Revert "add support for dynamic requests in require() and import()" (v…
1accf61 
…ercel/turborepo#7397)

Reverts vercel/turborepo#7153

Closes PACK-2511
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "add support for dynamic requests in require() and import()" (v…
108dd0f 
…ercel/turborepo#7397)

Reverts vercel/turborepo#7153

Closes PACK-2511
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
Revert "add support for dynamic requests in require() and import()" (v…
dfdeed4 
…ercel/turborepo#7397)

Reverts vercel/turborepo#7153

Closes PACK-2511
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
Revert "add support for dynamic requests in require() and import()" (v…
3fcf198 
…ercel/turborepo#7397)

Reverts vercel/turborepo#7153

Closes PACK-2511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sokra