add support for dynamic requests in require() and import() #7153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
a4b8e3b to
53f2bef
Compare
1 task
53f2bef to
dd4f59b
Compare
dd4f59b to
f472811
Compare
f472811 to
0be21e5
Compare
0be21e5 to
541fc3e
Compare
crates/turbopack-ecmascript-runtime/js/src/shared/runtime-utils.ts
Outdated
Show resolved
Hide resolved
| }; | ||
| match args.into_iter().next() { | ||
| Some(ExprOrSpread { spread: None, expr: key_expr }) => { | ||
| *expr = pm.create_import(*key_expr, import_externals); |
There was a problem hiding this comment.
It would be nice if pm.create_import could return a CallExpr so we could still use the visit_mut_call_expr visitor
There was a problem hiding this comment.
Technically possible, but not sure if I want to put so much internal knowledge into the signature...
| return Promise.resolve().then(() => { | ||
| throw e; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| return Promise.resolve().then(() => { | |
| throw e; | |
| }); | |
| return Promise.reject(e); |
There was a problem hiding this comment.
That's different. Promise.reject causes an unhandled rejection, but promise resolve throw allows to register a catch before the promise is rejected
There was a problem hiding this comment.
This doesn't seem to be the case?
You can try running this in node.js:
const process = require('node:process');
process.on('unhandledRejection', (reason, promise) => {
console.log('Unhandled Rejection at:', promise, 'reason:', reason);
});
function willReject() {
return Promise.reject(new Error("rejected with error"))
}
async function willCatch() {
try {
await willReject()
} catch(e) {
console.error("caught in try catch", e)
}
}
willReject().catch((err) => console.error("caught in handler", err))
willCatch()
| * flags: | ||
| * * 1: Error as rejected promise | ||
| */ | ||
| function moduleLookup( |
There was a problem hiding this comment.
maybe we can actually just combine this with requireContext?
(for import we could add another property)
just need to copy the generic error from here and maybe expand commonJsRequireContext in place instead of having it as a separate thing
There was a problem hiding this comment.
Yeah we should combine them. In a followup PR?
There was a problem hiding this comment.
I guess we can do that, will change all the snapshots again I guess
541fc3e to
944df3d
Compare
ForsakenHarmony
approved these changes
Feb 13, 2024
97acf54 to
b20d452
Compare
sokra
added a commit
that referenced
this pull request
Feb 15, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…rborepo#7153) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-986
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…rborepo#7153) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-986
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…rborepo#7153) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-986
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…rborepo#7153) ### Description Refactors `PatternMatching` to support a map of multiple matches by key. Based on the new `RequestKey` support for resolving. Code Generation for `require("./dir/"+ expr)` will emit a map of `__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr)`. The output format isn't really optimized yet, that's work for future PRs. ### Testing Instructions added a test case, enabled one previously skipped test case Closes PACK-986
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors
PatternMatchingto support a map of multiple matches by key. Based on the newRequestKeysupport for resolving.Code Generation for
require("./dir/"+ expr)will emit a map of__turbopack_lookup__({ "./a": () => ..., "./b": () => ... }, "./dir/" + expr).The output format isn't really optimized yet, that's work for future PRs.
Testing Instructions
added a test case, enabled one previously skipped test case
Closes PACK-986