这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(tasks-fs): allow to skip subpath invalidation #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

feat(tasks-fs): allow to skip subpath invalidation #7391

merged 1 commit into from
Feb 15, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 14, 2024 •
edited by padmaia
Loading

Description

This PR allows diskfilesystem to specify certain subpath to not to cause invalidations.

Notify doesn't support actively unwatching subpath yet, so this still setup the watcher normally - only the invalidation won't be notified for the turbopack.

Closes PACK-2495

@kwonoj kwonoj requested a review from a team as a code owner February 14, 2024 22:03
@vercel Vercel
Copy link

vercel bot commented Feb 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 11:00pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 11:00pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 11:00pm
rust-docs ❌ Failed (Inspect) Feb 14, 2024 11:00pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2024 11:00pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions GitHub Actions
Copy link
Contributor

✅ This change can build next-swc

@kwonoj kwonoj force-pushed the ignore-watcher-subpath branch from 3831cf6 to f90b1bf Compare February 14, 2024 22:08
@kwonoj kwonoj force-pushed the ignore-watcher-subpath branch from f90b1bf to 1aaca09 Compare February 14, 2024 22:18
@kwonoj kwonoj force-pushed the ignore-watcher-subpath branch from 1aaca09 to c56297f Compare February 14, 2024 22:32
@kwonoj kwonoj force-pushed the ignore-watcher-subpath branch from c56297f to 53a55b6 Compare February 14, 2024 22:42
@kwonoj kwonoj force-pushed the ignore-watcher-subpath branch from 53a55b6 to fdb66e2 Compare February 14, 2024 22:50
@kwonoj kwonoj force-pushed the ignore-watcher-subpath branch from fdb66e2 to 3bc874e Compare February 14, 2024 22:59
@kwonoj kwonoj merged commit 2e17f7c into main Feb 15, 2024
@kwonoj kwonoj deleted the ignore-watcher-subpath branch February 15, 2024 00:08
@sokra sokra mentioned this pull request Feb 15, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Feb 15, 2024
@sokra
update turbopack (#62080)
9572dfd 
* vercel/turborepo#7347 <!-- Tobias Koppers - avoid
resolving recursive main field -->
* vercel/turborepo#7349 <!-- Tobias Koppers - dedupe
resolving independent on reference type -->
* vercel/turborepo#7391 <!-- OJ Kwon -
feat(tasks-fs): allow to skip subpath invalidation -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kwonoj
feat(tasks-fs): allow to skip subpath invalidation (vercel/turborepo#…
cdc8b1e 
…7391)

### Description

This PR allows diskfilesystem to specify certain subpath to not to cause
invalidations.

Notify doesn't support actively unwatching subpath yet, so this still
setup the watcher normally - only the invalidation won't be notified for
the turbopack.

Closes PACK-2495
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kwonoj
feat(tasks-fs): allow to skip subpath invalidation (vercel/turborepo#…
7476090 
…7391)

### Description

This PR allows diskfilesystem to specify certain subpath to not to cause
invalidations.

Notify doesn't support actively unwatching subpath yet, so this still
setup the watcher normally - only the invalidation won't be notified for
the turbopack.

Closes PACK-2495
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kwonoj
feat(tasks-fs): allow to skip subpath invalidation (vercel/turborepo#…
3024a30 
…7391)

### Description

This PR allows diskfilesystem to specify certain subpath to not to cause
invalidations.

Notify doesn't support actively unwatching subpath yet, so this still
setup the watcher normally - only the invalidation won't be notified for
the turbopack.

Closes PACK-2495
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kwonoj
feat(tasks-fs): allow to skip subpath invalidation (vercel/turborepo#…
04aacc7 
…7391)

### Description

This PR allows diskfilesystem to specify certain subpath to not to cause
invalidations.

Notify doesn't support actively unwatching subpath yet, so this still
setup the watcher normally - only the invalidation won't be notified for
the turbopack.

Closes PACK-2495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwonoj @wbinnssmith