dedupe resolving independent on reference type #7349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
kwonoj
approved these changes
Feb 13, 2024
| request = *request | ||
| ) | ||
| }; | ||
| async move { |
There was a problem hiding this comment.
not a fan of adding indent to the whole function for tracing
There was a problem hiding this comment.
me neither, but .enter() doesn't work in async code...
There was a problem hiding this comment.
would rather have another function :^)
| let span = { | ||
| let lookup_path = lookup_path.to_string().await?; | ||
| let request = request.to_string().await?; | ||
| tracing::info_span!( |
There was a problem hiding this comment.
isn't this function traced twice now?
add more tracing to resolving steps
b08f8f5 to
0319e6f
Compare
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Feb 15, 2024
* vercel/turborepo#7347 <!-- Tobias Koppers - avoid resolving recursive main field --> * vercel/turborepo#7349 <!-- Tobias Koppers - dedupe resolving independent on reference type --> * vercel/turborepo#7391 <!-- OJ Kwon - feat(tasks-fs): allow to skip subpath invalidation -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * dedupe resolving independent on reference type * add more tracing to resolving steps ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2464
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * dedupe resolving independent on reference type * add more tracing to resolving steps ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2464
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * dedupe resolving independent on reference type * add more tracing to resolving steps ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2464
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * dedupe resolving independent on reference type * add more tracing to resolving steps ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Closes PACK-2464